Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set pin length after a RESET RETRY COUNTER call #158

Merged
merged 1 commit into from
May 23, 2023
Merged

Set pin length after a RESET RETRY COUNTER call #158

merged 1 commit into from
May 23, 2023

Conversation

sosthene-nitrokey
Copy link
Collaborator

We forgot to update the PIN length after RESET RETRY COUNTER calls, which lead to incorrect PIN length information which was not corrected unless the VERIFY was called before the next call to CHANGE REFERENCE DATA, which could lead to incorrect state.

@sosthene-nitrokey sosthene-nitrokey mentioned this pull request May 15, 2023
Closed
szszszsz
szszszsz reviewed May 15, 2023
View reviewed changes
Copy link
Member

@szszszsz szszszsz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The implementation for both, and with setting the PW1 should be shared ideally.

@sosthene-nitrokey sosthene-nitrokey merged commit ef8ee3b into main May 23, 2023
@sosthene-nitrokey sosthene-nitrokey deleted the pin-reset-length branch May 23, 2023 14:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@szszszsz szszszsz szszszsz left review comments

@robin-nitrokey robin-nitrokey robin-nitrokey approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sosthene-nitrokey @szszszsz @robin-nitrokey